Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task(SPV-1473) Prevent tools.go pattern from compiling generators into production binary #906

Conversation

ac4ch
Copy link
Contributor

@ac4ch ac4ch commented Feb 13, 2025

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@ac4ch ac4ch requested a review from a team as a code owner February 13, 2025 09:23
Copy link

github-actions bot commented Feb 13, 2025

Manual Tests

💚 Manual testing by @chris-4chain resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.65%. Comparing base (34b60ef) to head (b8e4673).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
- Coverage   36.67%   36.65%   -0.02%     
==========================================
  Files         410      410              
  Lines       19209    19209              
==========================================
- Hits         7044     7041       -3     
- Misses      11587    11589       +2     
- Partials      578      579       +1     
Flag Coverage Δ
unittests 36.65% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34b60ef...b8e4673. Read the comment docs.

@ac4ch ac4ch enabled auto-merge (squash) February 17, 2025 20:03
@chris-4chain chris-4chain added the tested PR was tested by a team member label Feb 19, 2025
@ac4ch ac4ch merged commit 138abf7 into main Feb 19, 2025
13 checks passed
@ac4ch ac4ch deleted the task/SPV-1473/Prevent_tools.go_pattern_from_compiling_generators_into_production_binary branch February 19, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants