Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example_cli: add feerate option to psbt new cmd #1840

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

example_cli: add feerate option to psbt new cmd #1840

wants to merge 4 commits into from

Conversation

ValuedMammal
Copy link
Contributor

The PR aims to add a --feerate option to the psbt New command.

Also in this PR:

  • bump bdk_coin_select to 0.4
  • fix collecting Assets and enable support for more descriptor types

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@ValuedMammal ValuedMammal self-assigned this Feb 17, 2025
@ValuedMammal ValuedMammal added this to the 2.0.0 milestone Feb 17, 2025
@ValuedMammal ValuedMammal force-pushed the example/cli-feerate branch 2 times, most recently from e66e131 to 4d754f3 Compare February 20, 2025 14:10
@ValuedMammal ValuedMammal force-pushed the example/cli-feerate branch 2 times, most recently from 8d785bd to 1b51e61 Compare February 28, 2025 22:49
oleonardolima
oleonardolima approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 1b51e61

It looks good, you probably need a rebase so CI can run after #1867 lands.

@ValuedMammal ValuedMammal removed this from the 2.0.0 milestone Mar 5, 2025
@ValuedMammal
example_cli: fix collect assets with for_each_key
7aab518 
which allows creating txs for more descriptor types.
@ValuedMammal
feat(example_cli): add feerate option to psbt new cmd
c68bce8
@ValuedMammal
deps(example_cli): bump bdk_coin_select to 0.4
8088b0a
@ValuedMammal
refactor(example_cli): clean up CLI docs
17280e5 
`--psbt` is a required arg for both Sign, Extract.

Change example_esplora --parallel-requests to 2 for easier
testing, debugging.
@ValuedMammal ValuedMammal force-pushed the example/cli-feerate branch from 1b51e61 to 17280e5 Compare March 7, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleonardolima oleonardolima oleonardolima approved these changes

Assignees

@ValuedMammal ValuedMammal

Labels
None yet
Projects
BDK Core
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValuedMammal @oleonardolima