-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add page for 3rd party bindings #100
base: master
Are you sure you want to change the base?
feat: add page for 3rd party bindings #100
Conversation
No the React Native bindings work well! They're just based on the 0.31.0 version of the bindings, so a bit older. I'm really hoping we can get them updated to 1.0 once that comes out. |
c0acb00
to
33a1059
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff, thanks for suggesting this page! We should have had that a long time ago.
Just 2 small comments but otherwise ready to go. Can you also see if you can remove Matthew's commit from the PR?
|
||
## ReactNative | ||
|
||
<a href="https://github.com/xsats/react-native-bdk" target="_blank">react-native-bdk</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bdk-rn library is this one! Sorry we never really made that clear.
@@ -0,0 +1,18 @@ | |||
# 3rd Party Bindings | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest the following sentence at the beginning:
Some organizations are maintaining their own wrappers and language bindings around the BDK libraries. While these are not maintained by the Foundation, they have users in production and are worth looking into!
issue: #99
I'm not 100% that these are the best/correct links.
I'm also not 100% that these are the only bindings available.
And idk what's going on with the ReactNative bindings, @thunderbiscuit made it sound like they aren't working for some reason? So maybe that link should be removed? But I do want to make it clear on this page that WASM works for RN either way.