Skip to content

fix: update build status link #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2024
Merged

fix: update build status link #38

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a31734
🐞 fix: update build status link & set leafHashes as optional
jasonandjay Jul 26, 2024
5000cf8
feat: set leafHashes as required, but allow empty
jasonandjay Jul 28, 2024
79289c1
fix: rollback TapBip32Derivation check
jasonandjay Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# bip174
[![Build Status](https://travis-ci.org/bitcoinjs/bip174.png?branch=master)](https://travis-ci.org/bitcoinjs/bip174)
[![Build Status](https://github.com/bitcoinjs/bip174/actions/workflows/main_ci.yml/badge.svg)](https://github.com/bitcoinjs/bip174/actions/workflows/main_ci.yml)
[![NPM](https://img.shields.io/npm/v/bip174.svg)](https://www.npmjs.org/package/bip174)

[![code style: prettier](https://img.shields.io/badge/code_style-prettier-ff69b4.svg?style=flat-square)](https://github.com/prettier/prettier)
Expand Down
14 changes: 7 additions & 7 deletions src/lib/converter/shared/tapBip32Derivation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,16 @@ function makeConverter(TYPE_BYTE) {
'masterFingerprint: Buffer; ' +
'pubkey: Buffer; ' +
'path: string; ' +
'leafHashes: Buffer[]; ' +
'leafHashes?: Buffer[]; ' +
'}';
function check(data) {
return (
Array.isArray(data.leafHashes) &&
data.leafHashes.every(
let leafHashesStatus = true;
if (data.leafHashes && data.leafHashes.length) {
leafHashesStatus = data.leafHashes.every(
leafHash => Buffer.isBuffer(leafHash) && leafHash.length === 32,
) &&
parent.check(data)
);
);
}
return leafHashesStatus && parent.check(data);
}
return {
decode,
Expand Down
15 changes: 8 additions & 7 deletions ts_src/lib/converter/shared/tapBip32Derivation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,16 +46,17 @@ export function makeConverter(
'masterFingerprint: Buffer; ' +
'pubkey: Buffer; ' +
'path: string; ' +
'leafHashes: Buffer[]; ' +
'leafHashes?: Buffer[]; ' +
'}';
function check(data: any): data is TapBip32Derivation {
return (
Array.isArray(data.leafHashes) &&
data.leafHashes.every(
let leafHashesStatus = true;
if (data.leafHashes && data.leafHashes.length){
leafHashesStatus = data.leafHashes.every(
(leafHash: any) => Buffer.isBuffer(leafHash) && leafHash.length === 32,
) &&
parent.check(data)
);
)
}

return leafHashesStatus && parent.check(data)
}

return {
Expand Down