Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newsletters: add 138 (2021-03-03) #523

Merged
merged 5 commits into from
Mar 3, 2021
Merged

Newsletters: add 138 (2021-03-03) #523

merged 5 commits into from
Mar 3, 2021

Conversation

harding
Copy link
Collaborator

@harding harding commented Mar 1, 2021 •
edited by jnewbery
Loading

jonatack
jonatack reviewed Mar 1, 2021
View reviewed changes
Copy link
Collaborator

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! The links seemed fine as well.

_posts/en/newsletters/2021-03-03-newsletter.md Outdated Show resolved Hide resolved
murchandamus
murchandamus reviewed Mar 1, 2021
View reviewed changes
_posts/en/newsletters/2021-03-03-newsletter.md Outdated Show resolved Hide resolved
_posts/en/newsletters/2021-03-03-newsletter.md Outdated Show resolved Hide resolved
_posts/en/newsletters/2021-03-03-newsletter.md Outdated Show resolved Hide resolved
_posts/en/newsletters/2021-03-03-newsletter.md Outdated Show resolved Hide resolved
@jnewbery
Copy link
Contributor

jnewbery commented Mar 2, 2021

Looks good to me so far. No review comments!

@harding
Copy link
Collaborator Author

harding commented Mar 2, 2021

Thanks for the feedback @jonatack, @xekyo, and @adamjonas! Edits made. Thanks for the writeups @jnewbery, @bitschmidty, @dongcarl, and @jonatack! I made some small additions, but everything else LGTM.

jonatack
jonatack reviewed Mar 2, 2021
View reviewed changes
_posts/en/newsletters/2021-03-03-newsletter.md
[news137 taproot activation]: /en/newsletters/2021/02/24/#taproot-activation-discussion
[sighash types]: https://btcinformation.org/en/developer-guide#signature-hash-types
[news135 blocksource]: /en/newsletters/2021/02/10/#rust-lightning-774
[0.19.0 segwit]: https://bitcoincore.org/en/releases/0.19.0.1/#mempool-and-transaction-relay
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, this link loses the anchor with the tor browser, which converts the url to e.g. http://6hasakffvppilxgehrswmffqurlcjjjhd76jgvaqmsg6ul25s7t3rzyd.onion/en/releases/0.19.0.1/ ...probably an edge case not worth bothering about but bitcoin/bitcoin#15846 works equally well (since GitHub doesn't provide an onion version)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can verify that it's something about BitcoinCore.org site specifically (not a problem common to all sites with a http-equiv="onion-location" tag), please open a bug on the BitcoinCore.org issue tracker and I'll look into it.

jnewbery
jnewbery reviewed Mar 3, 2021
View reviewed changes
Copy link
Contributor

@jnewbery jnewbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few small suggestions inline.

New topic links could be added for:

  • BIP70 replacement (BIP70 topic)
  • Fraud proofs in DLCs (DLCs topic - we now have three references, so maybe enough for a new topic page)
  • Documentation overhaul for HWI (HWI topic)

_posts/en/newsletters/2021-03-03-newsletter.md Outdated Show resolved Hide resolved
_posts/en/newsletters/2021-03-03-newsletter.md Show resolved Hide resolved
_topics/en/hwi.md Outdated Show resolved Hide resolved
@bitschmidty
Copy link
Contributor

New topic links could be added for:

  • BIP70 replacement (BIP70 topic)
  • Fraud proofs in DLCs (DLCs topic - we now have three references, so maybe enough for a new topic page)
  • Documentation overhaul for HWI (HWI topic)

Added topic references for bip70 and hwi for this newsletter

@bitschmidty bitschmidty force-pushed the 2021-03-03-newsletter branch from 51f3f87 to a81ba13 Compare March 3, 2021 12:15
@bitschmidty bitschmidty force-pushed the 2021-03-03-newsletter branch from a81ba13 to 9175eff Compare March 3, 2021 12:25
@bitschmidty bitschmidty merged commit db4d7da into bitcoinops:master Mar 3, 2021
@bitschmidty
Copy link
Contributor

Squashed and merged!

Thanks @harding @dongcarl @jnewbery @jonatack and @xekyo @adamjonas !

@jnewbery jnewbery mentioned this pull request Mar 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murchandamus murchandamus murchandamus left review comments

@jonatack jonatack jonatack left review comments

@bitschmidty bitschmidty bitschmidty left review comments

@jnewbery jnewbery jnewbery left review comments

@adamjonas adamjonas adamjonas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@harding @jnewbery @bitschmidty @adamjonas @jonatack @murchandamus @dongcarl