Motors: unify types for PWM to be uint16_t #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm trying to figure out if they where assigned uin32 in the first place. Looks like they originate from a pull-request and perhaps there is no real reason they are not uint16. For me it makes most sense to have them as uint16 so I'm approving the pull-request. Any other opinions? |
tobbeanton
approved these changes
May 31, 2024
|
We have looked at it and it is a good change, no idea why it became 32 bits and it should not break anything to change it back to 16 bit. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the uint16_t type more consistently. For uSD logging this will reduce the memory needed. For CRTP logging it should not have any impact, since the user-code requests the logging variables with a desired type. Thus, "legacy" code might request the logging variable as uint32_t and it will be converted accordingly.