Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Makefile for OOT app layer builds #1398

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Enhance Makefile for OOT app layer builds #1398

merged 3 commits into from
Aug 8, 2024

Conversation

gemenerik
Copy link
Member

@gemenerik gemenerik commented Aug 8, 2024 •
edited
Loading

This PR enhances the Makefile for out-of-Tree (OOT) / app layer builds by adding support for kbuild configuration GUIs and loading default configurations.

  • Added support for configuration GUIs:
    • Introduce targets for menuconfig, nconfig, xconfig, and gconfig
    • Example usage:
      In the app directory 
      make menuconfig
  • Load defconfig files
    • From configs folder
    • Example usage:
      In the app directory 
      make bolt_defconfig
  • Anything defined in OOT_CONFIG (e.g., app_config in app_hello_world) overwrites conflicting settings
  • Documentation

@gemenerik
Enhance Makefile for OOT app layer builds
9c93952 
- Added ability to load defconfig files (e.g., `make bolt_defconfig`) for configuration.
- Added support for kbuild configuration GUIs: menuconfig, nconfig, xconfig, and gconfig.
@gemenerik
Document OOT / app layer configuration options
16e9540
@gemenerik
Point to crazyflie base rather than relative
2e77b88
@gemenerik gemenerik marked this pull request as ready for review August 8, 2024 11:14
ToveRumar
ToveRumar approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@ToveRumar ToveRumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Very clear and easily understandable PR+Commits :)

@gemenerik gemenerik merged commit 515dedc into master Aug 8, 2024
25 checks passed
@gemenerik gemenerik deleted the rik/bl branch September 5, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToveRumar ToveRumar ToveRumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gemenerik @ToveRumar