Add flowcontrol requirement so that tests that need it will not get generated for devices that do not have it #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No device has this feature yet so no need to add it to any device type. FOr the future it would be nice to have type/property groups that a device can have etc
It the test does not have any fixtures it does not need any parametrization. The same goes for if the only fixture is the request firxture which is a default fixture added by the pytest framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, this is the only requirement we have.
However once we get more the idea is to create a yaml file where you can define types.
In this case CF2.1 and this type has several different properties.
Then this type will be set in the site yaml file for each device.
This will get rid of having skipped tests in each run.