Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NULLS FIRST / NULLS LAST qualifiers for ordering #341

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add NULLS FIRST / NULLS LAST qualifiers for ordering #341

wants to merge 5 commits into from

Conversation

matthewbauer
Copy link

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR.
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts).

@belevy
Copy link
Collaborator

belevy commented Oct 27, 2022

Please add tests to verify this behavior works as intended.

@matthewbauer matthewbauer requested a review from belevy October 27, 2022 19:34
belevy
belevy approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@belevy belevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, go ahead and add the changelog and bump the version

test/PostgreSQL/Test.hs
p3e <- insert' p3
p4e <- insert' p4
ret <- select $
from $ \p -> do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe switch to using the new syntax?

@sebastiant
Copy link

Would be great to see this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belevy belevy belevy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewbauer @belevy @sebastiant