Fix some shouldSatisfy predicates that were always True

test/Common/Record.hs

@@ -21,14 +21,14 @@
 module Common.Record (testDeriveEsqueletoRecord) where
 
 import Common.Test.Import hiding (from, on)
 import Control.Monad.Trans.State.Strict (StateT(..), evalStateT)
 import Data.Bifunctor (first)
 import Data.List (sortOn)
 import Data.Maybe (catMaybes)
 import Data.Proxy (Proxy(..))
 import Database.Esqueleto.Experimental
 import Database.Esqueleto.Internal.Internal (SqlSelect(..))
 import Database.Esqueleto.Record (
   DeriveEsqueletoRecordSettings(..),
   defaultDeriveEsqueletoRecordSettings,
   deriveEsqueletoRecord,
@@ -122,7 +122,7 @@
       }
 
 mySubselectRecordQuery :: SqlQuery (SqlExpr (Maybe (Entity Address)))
 mySubselectRecordQuery = do
   _ :& record <- from $
     table @User
       `leftJoin`
@@ -268,10 +268,10 @@
         liftIO $ sortedRecords !! 1
           `shouldSatisfy`
           (\case ( _ :& Just ( MyRecord { myName = "Some Guy"
                                         , myAddress = (Just (Entity addr2 Address {addressAddress = "30-50 Feral Hogs Rd"}))
                                         }
                               )) -> True
-                 _ -> True)
+                 _ -> False)
 
     itDb "can can handle joins on records with Nothing" $ do
         setup
@@ -291,7 +291,7 @@
                                         , myAddress = (Just (Entity addr2 Address {addressAddress = "30-50 Feral Hogs Rd"}))
                                         }
                               )) -> True
-                 _ -> True)
+                 _ -> False)
 
     itDb "can left join on nested records" $ do
         setup
@@ -312,7 +312,7 @@
                                                                     , myAddress = (Just (Entity addr2 Address {addressAddress = "30-50 Feral Hogs Rd"}))
                                                                     }
                                               })) -> True
-                 _ -> True)
+                 _ -> False)
 
     itDb "can handle multiple left joins on the same record" $ do
         setup
@@ -331,7 +331,7 @@
                                                                     , myAddress = (Just (Entity addr2 Address {addressAddress = "30-50 Feral Hogs Rd"}))
                                                                     }
                                               })) -> True
-                 _ -> True)
+                 _ -> False)
         liftIO $ sortedRecords !! 1
           `shouldSatisfy`
           (\case (_ :& _ :& Just (MyNestedRecord {myRecord = MyRecord {myName = "Rebecca", myAddress = Nothing}})) -> True