Restart all ws connections on packet delay setting update.#243
Open
tekwani wants to merge 4 commits intobitfinexcom:masterfrom
Open
Restart all ws connections on packet delay setting update.#243tekwani wants to merge 4 commits intobitfinexcom:masterfrom
tekwani wants to merge 4 commits intobitfinexcom:masterfrom
Conversation
Send heartbeat messages to ws connections to monitor ws server connection to check packet delay timeout for meta reload event.
avsek477
approved these changes
Aug 18, 2023
| packetWDDelay, | ||
| autoResumeAOs, | ||
| showOptInModal, | ||
| // showOptInModal, |
Contributor
There was a problem hiding this comment.
Optional: We can just remove it if not required. Same, for other respective comments.
tarcisiozf
suggested changes
Aug 21, 2023
| const strategyManager = session.getStrategyManager() | ||
| if (strategyManager) { | ||
| const { apiKey, apiSecret } = session.getCredentials() | ||
| strategyManager.restartConnection(apiKey, apiSecret, packetWDDelay) |
Comment on lines
+162
to
+166
| if (sinceLastMessage > this.packetWDDelay) { | ||
| return true | ||
| } | ||
|
|
||
| return false |
Contributor
There was a problem hiding this comment.
Suggested change
| if (sinceLastMessage > this.packetWDDelay) { | |
| return true | |
| } | |
| return false | |
| return sinceLastMessage > this.packetWDDelay |
Comment on lines
+152
to
+156
| if (sinceLastMessage > this.packetWDDelay) { | ||
| return true | ||
| } | ||
|
|
||
| return false |
Contributor
There was a problem hiding this comment.
Suggested change
| if (sinceLastMessage > this.packetWDDelay) { | |
| return true | |
| } | |
| return false | |
| return sinceLastMessage > this.packetWDDelay |
tarcisiozf
previously approved these changes
Aug 31, 2023
avsek477
approved these changes
Sep 1, 2023
# Conflicts: # lib/ws_servers/api/handlers/strategy/strategy_manager.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restart all ws connections on packet delay setting update.
Send heartbeat messages to ws connections to monitor ws server connection to check packet delay timeout for meta reload event.