Rename account on background thread

[sunkup]

Purpose

Fix IllegalThreadStateException during account rename.

Short description

The important change is in AccountRepository.rename():

withContext(defaultDispatcher) {
    automaticSyncManager.get().updateAutomaticSync(newAccount)
}

but please also check the @WorkerThread annotations make sense to you. We could annotate the whole AutomaticSyncManager class, but disableAutomaticSync() does not need an annotation, so only used in on the methods.

• Ensured account settings are always created on a background thread by adding withContext and injected default dispatcher.
• Added @WorkerThread annotations where deemed appropriate
• Injected @DefaultDispatcher in for this issue relevant places of the app (not everywhere)
• added tests. Mostly for verifying important methods were called. The more substantial ones are testRename_checksForAlreadyExisting and testRename_renamesAccountInAndroid. I think functionality of the other methods should be tested in their respective testclasses. If we were to test their functionality here in multiple test methods and additionally somewhere else we end up with a lot of dupliacated testing and tests.

Checklist

• The PR has a proper title, description and label.
• I have self-reviewed the PR.
• I have added documentation to complex functions and functions that can be used by other modules.
• I have added reasonable tests or consciously decided to not add tests.

[Copilot]

Pull Request Overview

This PR fixes an IllegalThreadStateException during account rename by ensuring background thread execution and adding proper thread annotations.

• Wraps automaticSyncManager.updateAutomaticSync() call in AccountRepository.rename() with withContext(defaultDispatcher) to ensure background thread execution
• Adds @WorkerThread annotations to methods that require background thread execution
• Replaces hardcoded Dispatchers.Default with injected @DefaultDispatcher for better testability and consistency

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
AccountRepository.kt	Main fix: wraps automatic sync update in background context, adds WorkerThread annotation to createBlocking method
AutomaticSyncManager.kt	Adds WorkerThread annotations to sync-related methods
TasksAppManager.kt	Adds WorkerThread annotation to selectProvider method
LoginScreenModel.kt	Replaces hardcoded Dispatchers.Default with injected defaultDispatcher
TasksModel.kt	Replaces hardcoded Dispatchers.Default with injected defaultDispatcher
App.kt	Replaces hardcoded Dispatchers.Default with injected defaultDispatcher
TestAccount.kt	Makes account name configurable for testing
AccountRepositoryTest.kt	Comprehensive test suite for rename functionality

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[rfc2822]

Looks good, also the tests and that more dispatchers are injected.

One comment