This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Fix GitHub teams for large orgs #613
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some large organisations have more than 100 teams. The current implementation only checks the first 100 teams returned by the API. This checks all teams the user is a member of. Added support for GitHub's new nested team feature which means inheritence works as designed. Again useful for large orgs. Updated the limit from 200 to the [documented limit of 100](https://developer.github.com/v3/#pagination).
|
Travis failing due to an error with dep. https://travis-ci.org/bitly/oauth2_proxy/jobs/387385489#L598 The last 3 master builds have failed due to issues with fsnotify.v1. It looks like #610 fixes this problem. |
|
I've tested the code from this PR on large Github org, all works good. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some large organisations have more than 100 teams. The current
implementation only checks the first 100 teams returned by the
API. This checks all teams the user is a member of.
Added support for GitHub's new nested team feature which means
inheritence works as designed. Again useful for large orgs.
Updated the limit from 200 to the documented limit of
100.