Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BITMAKER-4038: Add optional Sentry monitoring to the estela API #236

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mgonnav
Copy link
Contributor

@mgonnav mgonnav commented Nov 20, 2023

Description

  • Add optional Sentry monitoring to the estela API

Issue

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines of this project.
  • I have made corresponding changes to the documentation.
  • New and existing tests pass locally with my changes.
  • If this change is a core feature, I have added thorough tests.
  • If this change affects or depends on the behavior of other estela repositories, I have created pull requests with the relevant changes in the affected repositories. Please, refer to our official documentation.
  • I understand that my pull request may be closed if it becomes obvious or I did not perform all of the steps above.

@mgonnav
Copy link
Contributor Author

mgonnav commented Oct 24, 2024

@joaquingx The Sentry configuration here seems outdated, so a fresh look at this integration is needed. Some things to improve would be that the import of Sentry should be conditional on whether the user wants it. May as well close this, or keep it open to not forget about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant