Skip to content

[multus-cni] Add --multus-kubeconfig-file-host arg#31045

Merged
migruiz4 merged 7 commits intobitnami:mainfrom
brightdroid:fix_30606
Jan 23, 2025
Merged

[multus-cni] Add --multus-kubeconfig-file-host arg#31045
migruiz4 merged 7 commits intobitnami:mainfrom
brightdroid:fix_30606

Conversation

@brightdroid
Copy link
Copy Markdown
Contributor

Description of the change

Adds --multus-kubeconfig-file-host with path to hosts kubeconfig file for multipath.

Benefits

Make the chart work with e.g. k3s.

Applicable issues

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Christoph Roeder <chris@roeder.io>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Dec 16, 2024
@github-actions github-actions Bot removed the triage Triage is needed label Dec 16, 2024
@github-actions github-actions Bot removed the request for review from carrodher December 16, 2024 07:41
@github-actions github-actions Bot requested a review from migruiz4 December 16, 2024 07:41
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 1, 2025

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions Bot added the stale 15 days without activity label Jan 1, 2025
@brightdroid
Copy link
Copy Markdown
Contributor Author

Any update when this gets reviewed?

Thank you and a great new year.

@github-actions github-actions Bot removed the stale 15 days without activity label Jan 2, 2025
@github-actions
Copy link
Copy Markdown

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions Bot added the stale 15 days without activity label Jan 18, 2025
@github-actions
Copy link
Copy Markdown

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot added stale 15 days without activity and removed stale 15 days without activity labels Jan 23, 2025
@brightdroid
Copy link
Copy Markdown
Contributor Author

Please review

@carrodher carrodher reopened this Jan 23, 2025
@carrodher carrodher removed the stale 15 days without activity label Jan 23, 2025
@carrodher carrodher removed the solved label Jan 23, 2025
@github-actions github-actions Bot added the triage Triage is needed label Jan 23, 2025
@github-actions github-actions Bot requested a review from javsalgar January 23, 2025 08:59
@carrodher carrodher removed the request for review from javsalgar January 23, 2025 09:00
@carrodher carrodher removed the triage Triage is needed label Jan 23, 2025
Bitnami Containers and others added 3 commits January 23, 2025 09:00
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Carlos Rodríguez Hernández <carlos.rodriguez-hernandez@broadcom.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@migruiz4 migruiz4 changed the title fixes #30606 by adding path to kubeconfig as args [multus-cni] Add --multus-kubeconfig-file-host arg Jan 23, 2025
migruiz4
migruiz4 previously approved these changes Jan 23, 2025
Copy link
Copy Markdown
Member

@migruiz4 migruiz4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the late response @brightdroid, the changes look good to me.

Thank you for your contribution!

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@migruiz4 migruiz4 merged commit ca6f16d into bitnami:main Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

multus-cni solved verify Execute verification workflow for these changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bitnami/multus-cni] failed to get context for the kubeconfig

5 participants