Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/common] Option to add "app.kubernetes.io/component" label #31302

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bonddim
Copy link

@bonddim bonddim commented Jan 11, 2025

Description of the change

Provide option for labels templates to include app.kubernetes.io/component label

Benefits

Reduce code duplication in multi-component charts.

For example:

spec:
  selector:
    matchLabels: {{- include "common.labels.matchLabels" ( dict "customLabels" $podLabels "context" $ ) | nindent 6 }}
      app.kubernetes.io/component: controller
  template:
    metadata:
      labels: {{- include "common.labels.standard" ( dict "customLabels" $podLabels "context" $ ) | nindent 8 }}
        app.kubernetes.io/component: controller

Could be changed to:

spec:
  selector:
    matchLabels: {{- include "common.labels.matchLabels" ( dict "customLabels" $podLabels "context" $ "component" "controller" ) | nindent 6 }}
  template:
    metadata:
      labels: {{- include "common.labels.standard" ( dict "customLabels" $podLabels "context" $ "component" "controller") | nindent 8 }}

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added common triage Triage is needed labels Jan 11, 2025
@github-actions github-actions bot requested a review from carrodher January 11, 2025 09:04
@bonddim bonddim force-pushed the common-labels-component branch from c6bb940 to 00f9cfa Compare January 11, 2025 09:10
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jan 11, 2025
@github-actions github-actions bot removed the triage Triage is needed label Jan 11, 2025
@github-actions github-actions bot removed the request for review from carrodher January 11, 2025 18:10
@github-actions github-actions bot requested a review from jotamartos January 11, 2025 18:10
@github-actions github-actions bot removed the request for review from jotamartos January 22, 2025 17:24
@github-actions github-actions bot requested a review from fmulero January 22, 2025 17:24
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Feb 15, 2025
@bonddim
Copy link
Author

bonddim commented Feb 15, 2025

/active

@github-actions github-actions bot removed the stale 15 days without activity label Feb 16, 2025
Copy link

github-actions bot commented Mar 3, 2025

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Mar 3, 2025
@bonddim bonddim force-pushed the common-labels-component branch from a7924b0 to 0ce81f4 Compare March 5, 2025 12:12
@github-actions github-actions bot removed the stale 15 days without activity label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common in-progress verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants