Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/grafana-tempo] Add persistence options for Grafana Tempo metrics generator #31495

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NeonSludge
Copy link
Contributor

Description of the change

This PR converts the Grafana Tempo metrics generator Deployment into a StatefulSet and adds configurable persistence parameters.

Benefits

The Grafana Tempo metrics generator can now optionally write its WAL to persistent storage. This is important when using the local-blocks processor to enable metrics queries on historical data. This processor requires the traces WAL to be activated (the traces_storage.path option). When this WAL is stored on an emptyDir volume a metrics generator deployment restart will lead to some data loss since the WAL files wil not be available for replay after the restart.

Possible drawbacks

Applicable issues

Additional information

The official tempo-distributed Helm chart allows to deploy the metrics generator as a StatefulSet with persistent volumes (this is disabled by default).This PR also disables the persistence by default to match this behavior.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jan 21, 2025
@github-actions github-actions bot removed the triage Triage is needed label Jan 21, 2025
@github-actions github-actions bot removed the request for review from carrodher January 21, 2025 17:15
@github-actions github-actions bot requested a review from migruiz4 January 21, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grafana-tempo in-progress verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants