Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/mongodb] Use actual hostname instead of localhost for mongodb_exporter URI string #32192

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lasseoe
Copy link

@lasseoe lasseoe commented Feb 27, 2025

Description of the change

With this change, the metrics container will use the actual pod hostname, instead of localhost for the MongoDB URI.

Benefits

In an mTLS setup, the metrics container is not allowed to connect to localhost, because "localhost" is not a valid hostname in the certificates, and shouldn't be either.

Possible drawbacks

None

Applicable issues

Additional information

None

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added mongodb triage Triage is needed labels Feb 27, 2025
@github-actions github-actions bot requested a review from javsalgar February 27, 2025 09:31
@lasseoe lasseoe force-pushed the prom-exporter-mtls-hostname branch from 190f314 to 4b59245 Compare February 27, 2025 09:39
@javsalgar
Copy link
Contributor

Hi!

Thank you so much for the PR! Could you fix the DCO issue?

@lasseoe
Copy link
Author

lasseoe commented Feb 27, 2025

Hi!

Thank you so much for the PR! Could you fix the DCO issue?

There, all fixed :)

lasseoe and others added 3 commits February 27, 2025 20:13
@lasseoe lasseoe force-pushed the prom-exporter-mtls-hostname branch from 8011ef3 to 339bc46 Compare February 27, 2025 19:28
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Feb 27, 2025
@github-actions github-actions bot removed the triage Triage is needed label Feb 27, 2025
@github-actions github-actions bot removed the request for review from javsalgar February 27, 2025 20:02
@github-actions github-actions bot requested a review from migruiz4 February 27, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress mongodb verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/mongodb] metrics exporter doesn't work with mTLS
5 participants