[bitnami/nginx] shutting down gracefully #75942
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 6y <[email protected]> Signed-off-by: tommyluk <[email protected]>
tlserver
force-pushed
the
65691-gracefully-shutdown
branch
from
0724bb8 to
4951fc1
Compare
carrodher
added
verify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This pull request adds
STOPSIGNAL SIGQUITto the Dockerfile for Nginx. This change allows Nginx to handle shutdown signals more gracefully.Benefits
By implementing this change, when
docker stopis called, Nginx will be able to shut down gracefully, improving service reliability and user experience during container shutdowns.Possible Drawbacks
If immediate termination of Nginx is required, users must specify
--stop-signal SIGTERMwhen running or creating containers. This retains flexibility for users who prefer the default behavior.Applicable Issues
Additional Information
For more details on signal handling in Nginx, please refer to the official documentation: Nginx Runtime Control.