Adds Google Drive OAuth support #75
Conversation
| const authInfo = authContextStore.get(sessionId); | ||
|
|
||
| if (authInfo && (authInfo.atlassian || authInfo.figma)) { | ||
| if (authInfo && (authInfo.atlassian || authInfo.figma || authInfo.google)) { |
There was a problem hiding this comment.
I think we should do some cleanup to make our auth providers more abstract and code like this just loops through them.
There was a problem hiding this comment.
I would suggest creating a new ticket to improve the overall authentication code. I would rather not add new code to the current implementation on this MR. Do you mind creating a ticket and assigning it to me?
|
|
||
| if (googleTokens && googleTokens.access_token && googleTokens.refresh_token) { | ||
| console.log(' Adding Google credentials to JWT'); | ||
| multiProviderTokens.google = { |
There was a problem hiding this comment.
similar here, this code is the same for each provider
There was a problem hiding this comment.
Same as before. This can be added to the next ticket for authentication improvement.
| <div class="provider ${connectedProviders.includes('google') ? 'connected' : ''}"> | ||
| <h2>Google Drive</h2> | ||
| <p>Access Google Drive files and user information</p> |
There was a problem hiding this comment.
probably just "google drive" files
| async refreshAccessToken( | ||
| params: RefreshTokenParams | ||
| ): Promise<StandardTokenResponse> { | ||
| const clientId = process.env.GOOGLE_CLIENT_ID!; |
There was a problem hiding this comment.
I think we need to update the contributing docs and point people where to create a google_client_id and such.
There was a problem hiding this comment.
Will be addressed on https://bitovi.atlassian.net/browse/FE-721
TICKET: https://bitovi.atlassian.net/browse/FE-662
This pull request adds support for Google Drive as a new OAuth provider throughout the authentication and token management flow. The changes ensure Google credentials are handled alongside existing Atlassian and Figma providers, including connection, token refresh, JWT creation/validation, and provider registration. The update also introduces a Google API client for authenticated requests.
Google Drive provider integration:
googleas an optional provider in theAuthContext,MultiProviderTokens, and related type definitions, enabling storage and handling of Google OAuth tokens. [1] [2]Token refresh and management:
Provider registration and API client:
google-api-client.tsfile implementing a Google API client for authenticated requests using OAuth tokens, including a method to fetch user info from the Drive API.Error handling and messaging:
These changes collectively enable Google Drive integration for authentication, session management, and API access within the existing multi-provider framework.