[BCN] Lint bitcore-node #4032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kajoseph merged 8 commits into bitpay:master from MicahMaphet:lint

Oct 30, 2025

Contributor

MicahMaphet commented Oct 22, 2025

This PR:

Lints bitcore-node with the new eslint rules


          linted bitcore-node

9fe73e0

kajoseph reviewed

View reviewed changes

packages/bitcore-node/package.json Outdated Show resolved Hide resolved


          readded precommit to bitcore node and fixed eslint errors

a99f167

MicahMaphet commented

View reviewed changes

packages/bitcore-node/scripts/addGenesisBlock.js Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/scripts/purgeNetworkData.js Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/scripts/setTxAsReplaced.js Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/src/chain.ts Outdated Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/src/models/transaction.ts Outdated Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/src/modules/index.ts Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/src/modules/ripple/api/csp.ts Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/src/providers/chain-state/evm/api/csp.ts Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/src/providers/chain-state/evm/api/gnosis.ts Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/src/providers/chain-state/evm/models/block.ts Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/src/providers/chain-state/evm/p2p/sync.ts Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/src/providers/chain-state/evm/p2p/sync.ts Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/src/providers/chain-state/evm/types.ts Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/src/providers/chain-state/svm/api/csp.ts Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/src/providers/libs/index.ts Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/src/server.ts Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/src/types/Mapping.ts Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/src/types/SupportedChain.ts Show resolved Hide resolved


          made parameters in bitcore-lib optional to prevent typescript import …

b1bb901

…errors

MicahMaphet commented

View reviewed changes

packages/bitcore-node/test/integration/bitcoin/csp.spec.ts Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/test/integration/websocket.spec.ts Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/test/unit/models/transaction.spec.ts Show resolved Hide resolved

MicahMaphet commented

View reviewed changes

packages/bitcore-node/test/verification/db-verify-headers.ts Show resolved Hide resolved


          fixed benchmark.ts in bitcore-node

ae4683e

MicahMaphet force-pushed the lint branch from d275b33 to ae4683e Compare

October 22, 2025 21:18

MicahMaphet added 2 commits

October 22, 2025 17:21


          silenced errors for /**** in scripts to avoid /** **

4b7246c


          refactored chain.ts to use import instead of require; replaced added …

979a779

…types properly to for of loops

kajoseph requested changes

View reviewed changes

Collaborator

kajoseph left a comment

Still reviewing, but here's some feedback in the meantime which involve adding new rules that might affect other files.

packages/bitcore-node/src/providers/chain-state/evm/types.ts Outdated Show resolved Hide resolved

kajoseph reviewed

View reviewed changes

packages/bitcore-node/src/chain.ts Outdated Show resolved Hide resolved

packages/bitcore-node/src/routes/api/tx.ts Outdated Show resolved Hide resolved

packages/bitcore-node/src/server.ts Outdated Show resolved Hide resolved

kajoseph reviewed

View reviewed changes

packages/bitcore-node/test/integration/websocket.spec.ts Outdated Show resolved Hide resolved

MicahMaphet added 2 commits

October 28, 2025 13:12


          implented kenny's suggestions: import from crypto-wallet-core instead…

a09cfdf

… of bitcore-lib and replaced eslint disable lines


          added whitespace linting rule

aef6465

kajoseph approved these changes

View reviewed changes

Collaborator

kajoseph left a comment

LGTM

Nice work!

kajoseph merged commit cd55770 into bitpay:master

13 of 14 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet