Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use mysql compatible configuration and allow duplicate keys in mysqlConf field #932

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use mysql compatible configuration and allow duplicate keys in mysqlConf field #932

wants to merge 1 commit into from

Conversation

usernameisnull
Copy link

@usernameisnull usernameisnull commented Oct 10, 2024 •
edited
Loading

related issue: #931
change spec.mysqlConf field: map[string]map[string]intstr.IntOrString -> string, compatible with original mysql ini configurations

  • allow boolean configuration, only key
  • allow duplicate field

like below:

mysqlConf: |-
    performance-schema # only key
    binlog-format = ROW
    binlog_do_db = db4
    binlog_do_db = db5

in the running mysql instance:
image

the conf in the running instance:
image

  • I've made sure the CHANGELOG.md will remain up-to-date after this PR is merged.

@usernameisnull usernameisnull force-pushed the feat/allow-duplicate-key-in-configuration branch 6 times, most recently from 141bfef to 504805e Compare October 12, 2024 17:04
@usernameisnull usernameisnull force-pushed the feat/allow-duplicate-key-in-configuration branch from 504805e to 726d2c3 Compare October 13, 2024 04:47
@usernameisnull
Copy link
Author

PTAL @cndoit18 @calind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@usernameisnull