Add streaming order book support for CEX.IO #275
Conversation
.../main/java/info/bitrich/xchangestream/cexio/dto/CexioWebSocketOrderBookSubscriptionData.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thank you for your first contribution, @BenjaminTrapani!
This looks great.
A few comments and questions then we can get this show on the road.
...ge-cexio/src/main/java/info/bitrich/xchangestream/cexio/CexioStreamingMarketDataService.java
Outdated
Show resolved
Hide resolved
xchange-cexio/src/main/java/info/bitrich/xchangestream/cexio/CexioStreamingRawService.java
Outdated
Show resolved
Hide resolved
xchange-cexio/src/main/java/info/bitrich/xchangestream/cexio/CexioStreamingRawService.java
Outdated
Show resolved
Hide resolved
xchange-cexio/src/main/java/info/bitrich/xchangestream/cexio/CexioAdapters.java
Outdated
Show resolved
Hide resolved
xchange-cexio/src/main/java/info/bitrich/xchangestream/cexio/CexioAdapters.java
Outdated
Show resolved
Hide resolved
existing code that does that.
currency pair match private implementation in XChange exactly
…hub.com/BenjaminTrapani/xchange-stream into user/betrapan/cexio-streaming-orderbook
|
@badgerwithagun These changes should be ready to go now. I reformatted xchange-cexio per the mvn format used in xchange in the final commit, so it is easiest to read the updates by looking at the diffs for the individual commits before 3e16614. |
|
@badgerwithagun Ping on this one. Is there anything I missed in the feedback? How does the most recent iteration look? If it looks alright, I'll sync up with latest develop. |
|
Hey @BenjaminTrapani, sorry, I've been busy. Will look at this ASAP. |
|
OK, sorry about the delay @BenjaminTrapani . It's clear there's no-one else using CEX.IO, so I'm just going to take a leaf out of the XChange project's book and merge this. It can't hurt if only you are affected! |
The code still needs to be formatted per mvn com.coveo:fmt-maven-plugin:format. The original source was not formatted per this extension, so let's revert commit 9eb03e0 right before merging to restore the correct format.