#446 Bitstamp v2 not getting trades - fixed

[pchertalev]

No description provided.

[jurepetrovic]

Hello,

@pchertalev
No, I don't mind better changes, just so it works smooth and I can use it in production ;-)

I see you used existing JSON mapping class.
I didn't want to do it, because it's already used in v1 of the protocol.
info.bitrich.xchangestream.bitstamp.BitstampStreamingMarketDataService, line 64.

If this doesn't break compatibility I don't mind.
Or do you want to throw v1 support completely out?

[pchertalev]

There is only one version of BitstampAdapters class in XChange 4.4, there is no v2.BitstampAdapters, and there is no other method BitstampAdapters.adaptTrade for v2 version. So I don't see any other way - we must use BitstampTransaction class because it is used as parameter BitstampAdapters.adaptTrade. BitstampWebSocketTransaction is just wrapper for adapting input json fields to BitstampTransaction fileds.
As you see I used BitstampOrderBook class without wrapper as well because websocket json format is completely match and it is required for BitstampAdapters.adaptOrderBook method. BitstampOrderBook has all required Jackson annotations for parsing - this allow us to avoid other classes in code.
About cutting out v1 - I have checked Bitstamp V1 pusher service still works and it can be used by someone. So I don't see reason to remove it so far.
I don't know why v1 version contains special empty channel prefix for BTC_USD, but I checked - it works :) Actually it works with one as well but I did not touch this :)

private String getChannelPostfix(CurrencyPair currencyPair) {
    if (currencyPair.equals(CurrencyPair.BTC_USD)) { 
        return "";
    }
    return "_" + currencyPair.base.toString().toLowerCase() + currencyPair.counter.toString().toLowerCase();
}

[jurepetrovic]

Ok, if BitstampWebTransaction works for v1 and v2 trades, it looks perfect to me ;)

You need something from me to merge?

As soon as you guys put it in develop branch of main repo,
I'll go after it and use it in production.

Thanks,
Jure

[pchertalev]

@Flemingjp @badgerwithagun Hi guys, if you have a time, please look at this PR

[mdvx]

#446 (comment)

I see the side calculation is in BitstampAdapters.adaptTrade

• OrderType orderType = tx.getType() == 0 ? OrderType.BID : OrderType.ASK;
  which matches the https://www.bitstamp.net/websocket/v2/ spec

So I guess Bitstamp's own website is displaying it wrong.

[mdvx]

oops duplicate

[mdvx]

looks good to me

[badgerwithagun]

One thing spotted with the changed code.