Skip to content
This repository has been archived by the owner on Jun 8, 2020. It is now read-only.

Making all online tests @Ignore to allow build to work with no Internet connection. Fixes #357 #530

Closed
wants to merge 5 commits into from

Conversation

TSavo
Copy link
Contributor

@TSavo TSavo commented Mar 2, 2020

Sometimes tests that require an active connection to exchange cause the build to fail because of a problem on the exchange side. This PR changes all the online tests to @ignore to avoid any possible build errors due to remote services being unavailable. Fixes #357

To find these I literally unplugged my internet connection and ran all the tests, only @ignore -ing the ones which failed.

Copy link
Collaborator

@badgerwithagun badgerwithagun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been thinking about this one. Could we instead mark these with a @Category (along with. BitmexTest) or use an ...Integration suffix, and exclude them from the CI build using a Maven profile? That way the tests will still run when the build is run manually but we can avoid the CI build being flakey (or they can be excluded at the command line if you're working offline).

@badgerwithagun
Copy link
Collaborator

Or... Rather than using a profile, we could shift the matching tests to running in failsafe instead of surefire, and allow the build to pass if failsafe reports errors.

@TSavo
Copy link
Contributor Author

TSavo commented Mar 2, 2020

Or... Rather than using a profile, we could shift the matching tests to running in failsafe instead of surefire, and allow the build to pass if failsafe reports errors.

I will look into that! :)

@TSavo
Copy link
Contributor Author

TSavo commented Mar 4, 2020

Closing this PR to do a failsafe integration instead.

@TSavo TSavo closed this Mar 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BitmexTest fails intermittently
2 participants