Add failsafe integration test runner, rename integration tests #540
Conversation
Merge in latest
Merge in latest from upstream
Merge latest from upstream
…ration tests. Change existing integration tests to *IT.java.
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-failsafe-plugin</artifactId> | ||
| <version>3.0.0-M4</version> | ||
| <configuration> |
There was a problem hiding this comment.
I'd like to skip running these entirely on the Travis build - they take a lot of wasted time. Could you add an argument to do that and set the travis build to use it?
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| import info.bitrich.xchangestream.core.StreamingExchange; | |||
| import java.math.BigDecimal; | |||
| import org.junit.Ignore; | |||
|
|
|||
There was a problem hiding this comment.
Any chance of changing all those ...Example classes which use main methods to use this pattern too? (Feel free to say "some other time" - it would just be nice to do it all at once).
badgerwithagun
added
the
awaiting_fixes
|
This project is in the process of being merged into the XChange project and no further PRs will be merged here. Once the projects have been merged, there may be a short stabilization period where there will be large-scale renaming of classes and packages, which may cause conflicts. You are advised to wait at least a week from now and then resubmit your PR on the XChange project. Thank you for your support! |
|
@TSavo, I'm keen to get this done since it is an obvious difference between all the streaming modules and polling modules on XChange. Are you in a position to resubmit this PR on the XChange project? |
|
I will be in a few days, yes. :)
…On Fri, May 8, 2020 at 11:02 AM Graham Crockford ***@***.***> wrote:
@TSavo <https://github.com/TSavo>, I'm keen to get this done since it is
an obvious difference between all the streaming modules and polling modules
on XChange. Are you in a position to resubmit this PR on the XChange
project?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#540 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGWLJTNBPVB3NLQFSMUENTRQRCJ7ANCNFSM4LAYMXJQ>
.
|
There are a number of integration tests which are presently ignored by the maven build. Rather than ignore them, this PR renames them to *IT.java, and adds the failsafe maven plugin, configuring it to not fail the build on a failed integration tests.
This paves the way for more integration tests without fear of failing the build if the exchange is down. The integration tests have been added to the following goals:
To run the tests, simply run
mvn verify. To run only the integration tests, runmvn integration-test.