Skip to content
This repository has been archived by the owner on Jun 8, 2020. It is now read-only.

Remove compiler warnings #541

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ private static void rateLimit() {
LOG.warn("Bitfinex connection throttle control has been interrupted");
}
}

@SuppressWarnings("deprecation")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not remove the use of the untrusted API?

Not sure suppressing the warning is the right thing to do here - a warning is warranted.

public static void main(String[] args) throws Exception {
CertHelper.trustAllCerts();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ public class BitmexAuthenticatedExample {

private static final Logger LOG = LoggerFactory.getLogger(BitmexAuthenticatedExample.class);

@SuppressWarnings("deprecation")
public static void main(String[] args) throws Exception {
CertHelper.trustAllCerts();
StreamingExchange exchange =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ public class BitmexDeadManSwitchTest {

@Test
@Ignore
@SuppressWarnings("deprecation")
public void testDeadmanSwitch() throws Exception {
CertHelper.trustAllCerts();
BitmexStreamingExchange exchange =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ public class BitmexOrderReplaceTest {

@Test
@Ignore
@SuppressWarnings("deprecation")
public void testOrderReplace() throws Exception {
CertHelper.trustAllCerts();
BitmexStreamingExchange exchange =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ public class HitbtcStreamingServiceTest {

@Rule public ExpectedException thrown;

@SuppressWarnings("deprecation")
public HitbtcStreamingServiceTest() {
thrown = ExpectedException.none();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ public class LgoStreamingTradeServiceTest {
private SynchronizedValueFactory<Long> nonceFactory;

@Before
@SuppressWarnings("unchecked")
public void setUp() {
dateFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'");
dateFormat.setTimeZone(TimeZone.getTimeZone("UTC"));
Expand Down