Skip to content
This repository was archived by the owner on Jun 8, 2020. It is now read-only.

[Kraken] Subscription failure detection#550

Open
mladenmarkov wants to merge 4 commits intobitrich-info:developfrom
mladenmarkov:kraken-retry-subscribe
Open

[Kraken] Subscription failure detection#550
mladenmarkov wants to merge 4 commits intobitrich-info:developfrom
mladenmarkov:kraken-retry-subscribe

Conversation

@mladenmarkov
Copy link
Copy Markdown

@mladenmarkov mladenmarkov commented Mar 10, 2020

Automatically detect subscription failure (for example, due to exceeded request rate) and send an onError() notification to subscriber.

Add a test to confirm that reliable subscriptions to all 135 Kraken pairs can be achieved, using a simple retryWhen() operator.

Depends on #549

…e and send an onError() notification to subscriber.

Add a test to confirm that reliable subscriptions to all 135 Kraken pairs can be achieved, using a simple retryWhen() operator.
@badgerwithagun
Copy link
Copy Markdown
Collaborator

Thanks for this @mladenmarkov!

Reviewing now.

@badgerwithagun badgerwithagun added the awaiting_fixes PR is awaiting submitter to respond to a review label Mar 27, 2020
@badgerwithagun
Copy link
Copy Markdown
Collaborator

This project is in the process of being merged into the XChange project and no further PRs will be merged here. Once the projects have been merged, there may be a short stabilization period where there will be large-scale renaming of classes and packages, which may cause conflicts. You are advised to wait at least a week from now and then resubmit your PR on the XChange project. Thank you for your support!

@badgerwithagun
Copy link
Copy Markdown
Collaborator

You can now resubmit your PR on XChange. This project will shortly be marked as archived.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

awaiting_fixes PR is awaiting submitter to respond to a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants