FC updates to support Tanks and Taps #191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A helper function to check if a supplied type T can be stored in the static_variant
Add support to FC reflection for reflecting a class's members from within
the class itself, i.e.:
struct Foo {
int x;
char y;
FC_REFLECT_INTERNAL(Foo, (x)(y))
};
The reflection must still be declared to FC from within the global
namespace using FC_COMPLETE_INTERNAL_REFLECTION(Foo).
This is particularly useful for reflecting SFINAE template classes where
the members vary depending on the template parameters, i.e.:
template<typename T, typename = void>
struct Foo { int x; FC_REFLECT_INTERNAL(Foo, (x)) };
template<typename T>
struct Foo<T, std::enable_if_t<std::is_same<T, char>{}>> {
int x; char y; FC_REFLECT_INTERNAL(Foo, (x)(y))
};
Add some new features around filters, transforms, and a new runtime::make_array to convert a typelist to a runtime std::array
This template transforms a typelist by transforming each element to the application of that element to a provided template. Also, fix a bug in typelist::slice, where slice<list<void>, 1> did not compile.
C++ does not allow derived classes to inherit parent class constructors and assignment operators, which makes the static_variant<list<...>> shortcut create a somewhat crippled type. Remove the shortcut and require client code to use the more syntax-heavy typelist::apply<list<...>, static_variant>
This commit introduces a new fc::object_reflection<T> template which can be used to generate instrumentable mirror types which simulate reference access to reflected objects via methods, but these methods can be reconfigured by client code to do additional checking, logging, or recording of what data is read and written. Also add some new mutators for typelists: append, prepend, insert
nathanielhourt
added a commit
to nathanielhourt/bitshares-2
that referenced
this pull request
Mar 23, 2020
This adds compatibility to bitshares/hardfork for bitshares/bitshares-fc#191
nathanielhourt
added a commit
to nathanielhourt/bitshares-2
that referenced
this pull request
Mar 23, 2020
This adds compatibility to bitshares/hardfork for bitshares/bitshares-fc#191
|
I've just realized that while I can build bitshares' develop branch against this, I can't build hardfork unless I add my TNT updates. See bitshares/bitshares-core#2118 for updates to bitshares/hardfork to allow building against this version of FC. |
nathanielhourt
added a commit
to nathanielhourt/bitshares-2
that referenced
this pull request
Apr 4, 2020
This adds compatibility to bitshares/hardfork for bitshares/bitshares-fc#191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the updates I've made to FC to support Tanks and Taps. There's some interesting stuff in here:
hash160static_varianttypelistobject_reflectionto create instrumented pseudo-references to reflected types (see e1ed222)