Avoid potential corruption during unpack of static_variant #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
force-pushed
the
update-unpack-static-variant
branch
4 times, most recently
from
063995b to
ad82470
Compare
abitmore
force-pushed
the
update-unpack-static-variant
branch
from
ad82470 to
2d73734
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this PR was merged but later reverted in #253, and #254 is to redo it.
Before this change, when
sv.set_which(w.value)is already done and the followingsv.visit(...)throws, thestaic_variantobject passed into the function may be updated to something incomplete and may cause unintended problems.Although usually we don't reuse
static_variantvariables, it's not guaranteed.This does lead to additional data copy.
Reference: https://gitlab.syncad.com/hive/hive/-/merge_requests/1049