Added readiness check to avoid errors during topology changes #29
+373
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edescourtis
commented
Jan 12, 2022
| def start_node(name) do | ||
| :slave.start_link(:localhost, name) | ||
| end | ||
| def start_nodes(prefix, amount, options \\ []) |
There was a problem hiding this comment.
TODO: Add the hidden option to LocalCluster and delete this code.
erpc and nodes show up faster than the applications can start in some cases leading to requests being routed to booting nodes. A workaround is possible in the RPC call, but it leads to the proliferation of error handling code, so it would be better to wait for the nodes to be ready.
edescourtis
force-pushed
the
readiness
branch
from
b42e7b1 to
efc8540
Compare
|
@bitwalker Let me know if you want me to change something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
erpc and nodes show up faster than the applications can start in some
cases leading to requests being routed to booting nodes. A workaround is
possible in the RPC call, but it leads to the proliferation of error
handling code, so it would be better to wait for the nodes to be
ready.