Add wrapping around to key_to_nodes
#40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kindly pinging @Gazler as well :) |
ruslandoga
commented
Feb 10, 2025
| @@ -246,27 +246,32 @@ defmodule HashRing do | |||
|
|
|||
| case :gb_trees.iterator_from(hash, r) |> :gb_trees.next() do | |||
| {_key, node, iter} -> | |||
| find_nodes_from_iter(iter, count - 1, [node]) | |||
| find_nodes_from_iter(r, iter, count - 1, [node], _restarted? = false) | |||
There was a problem hiding this comment.
Not sure if restarted? is needed, but I added it to be safe.
On second though, if we count = min(length(nodes), count) it's not needed.
ruslandoga
commented
Feb 10, 2025
| results | ||
| :none -> | ||
| if restarted? do | ||
| Enum.reverse(results) |
There was a problem hiding this comment.
results were not reversed originally, but I think they need to be since the "happy path" does it (on line 257).
ruslandoga
changed the title
ruslandoga
changed the title
ruslandoga
changed the title
key_to_nodes
anas-ksibi
added a commit
to enreach-labs/libring
that referenced
this pull request
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
This is a possible fix for #39