Skip to content

Detect agent definitions in more places as well as skills #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
withinfocus merged 2 commits into from
Jan 6, 2026
Merged

Detect agent definitions in more places as well as skills #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4d3341
Detect agent definitions in more places as well as skills
withinfocus Jan 6, 2026
c352a47
Specify lengths more explicitly for validation
withinfocus Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions .github/workflows/validate-plugins.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,11 @@ jobs:
# Extract unique plugin directories from changed files
CHANGED_PLUGINS=$(echo "$CHANGED_FILES" | cut -d/ -f1-2 | sort -u | tr '\n' ' ' | sed 's/ $//')

# Filter for AGENT.md and hooks.json files
AGENT_FILES=$(echo "$CHANGED_FILES" | grep 'AGENT\.md$' || echo "")
# Filter for AGENT.md, SKILL.md, and hooks.json files
# Agent files are in plugins/*/agents/*/AGENT.md
AGENT_FILES=$(echo "$CHANGED_FILES" | grep '/agents/.*/AGENT\.md$' || echo "")
# Skill files are in plugins/*/skills/*/SKILL.md
SKILL_FILES=$(echo "$CHANGED_FILES" | grep '/skills/.*/SKILL\.md$' || echo "")
HOOK_FILES=$(echo "$CHANGED_FILES" | grep 'hooks\.json$' || echo "")

{
Expand All @@ -50,13 +53,16 @@ jobs:
echo "agent_files<<EOF"
echo "$AGENT_FILES"
echo "EOF"
echo "skill_files<<EOF"
echo "$SKILL_FILES"
echo "EOF"
echo "hook_files<<EOF"
echo "$HOOK_FILES"
echo "EOF"
} >> "$GITHUB_OUTPUT"

# Check if there are any plugin component files to validate
if [[ -n "$AGENT_FILES" ]] || [[ -n "$HOOK_FILES" ]]; then
if [[ -n "$AGENT_FILES" ]] || [[ -n "$SKILL_FILES" ]] || [[ -n "$HOOK_FILES" ]]; then
echo "has_components=true" >> "$GITHUB_OUTPUT"
else
echo "has_components=false" >> "$GITHUB_OUTPUT"
Expand Down Expand Up @@ -129,17 +135,27 @@ jobs:
Agent files changed:
${{ steps.changed-files.outputs.agent_files }}

Skill files changed:
${{ steps.changed-files.outputs.skill_files }}

Hook files changed:
${{ steps.changed-files.outputs.hook_files }}

Perform TWO types of validation:

## 1. Component Validation (using the plugin-dev agent)
For each AGENT.md and hooks.json file:
For AGENT.md files:
- Validate agent identifiers (3-50 chars, lowercase, hyphens only)
- Validate description length (10-5,000 chars)
- Validate system prompt length (20-10,000 chars)
- Check YAML frontmatter structure

For SKILL.md files:
- Validate skill name (max 64 chars)
- Validate description length (max 1024 chars)
- Check YAML frontmatter structure

For hooks.json files:
- Validate hook JSON schema
- Check hook event names
- Verify script paths use ${CLAUDE_PLUGIN_ROOT}
Expand Down