Skip to content

Conversation

@withinfocus
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

More testing on #15.

๐Ÿ“” Objective

The bug was in the invalid character check: [[ "$arg" =~ $'\0' ]] used a regex with $'\0' (null byte), which expands to an empty string, creating an invalid regex that matched everything. Changed from regex =~ to glob pattern matching == for newline and carriage return checks. Removed the null byte check entirely too -- bash strings can't contain null bytes anyway.

Removed the debug code as a result.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@withinfocus withinfocus requested a review from a team as a code owner January 7, 2026 15:06
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ bdc5891f-ddd3-4eea-b833-54fbb605469a

Great job! No new security vulnerabilities introduced in this pull request

@withinfocus withinfocus merged commit c14d1e4 into main Jan 7, 2026
11 checks passed
@withinfocus withinfocus deleted the full-fix branch January 7, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants