[PM-14880] Add release notes config #4295
Conversation
vvolkgang
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4295 +/- ##
=======================================
Coverage 89.01% 89.01%
=======================================
Files 453 453
Lines 39064 39064
Branches 5482 5482
=======================================
Hits 34771 34771
Misses 2369 2369
Partials 1924 1924 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
| authors: | ||
| - renovate[bot] |
There was a problem hiding this comment.
authors is only available in exclude section => changelog.categories[*].exclude.authors; so I think this config won't work or do anything.
Additionally, maybe we could have PRs created by renovate[bot] automatically have one of the labels listed below so to be added to this category.
| - title: ':tada: Exciting New Features' | ||
| labels: | ||
| - '*' | ||
| exclude: | ||
| authors: | ||
| - renovate[bot] |
There was a problem hiding this comment.
🤔 Shouldn't we exclude the labels of the other categories here? So e.g. a PR labeled with bug is not listed as an exciting new feature.
There was a problem hiding this comment.
This applies to the other comments too, all of these were put in place to test how their implementation reacts to misconfiguration. I'll update the description to note that.
| - tests-only | ||
| - refactor | ||
| - tests-only |
There was a problem hiding this comment.
⛏️ tests-only is repeated.
🤔 I see tests-only excluded in the exclude top section, which one takes precedence?
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14880
📔 Objective
Adds a configuration file for GitHub automated release notes, as an first iteration to test this functionality. This won't be the final version of this file, as we need to test how the functionality reacts to misconfiguration.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes