[PM-13349] Hide edit button unless item is in at least one non-readOnly collection

[mpbw2]

Hide edit button unless item is in at least one non-readOnly collection

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13349

📔 Objective

Hide the edit button (FAB) if an item is in a readOnly collection, or in the case of multiple collections at least one has to be non-readOnly or the button remains hidden.

📸 Screenshots

Item view from within non-readOnly (editable) collection:

Item view from within readOnly (non-editable) collection:

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
  issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 975f7725-eccc-4180-8c9b-66288c48fab8

Fixed Issues

Severity	Issue	Source File / Package
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 886

[eliykat]

The server evaluates this business logic for you and sets the result in the cipher.edit property.

• true if the user can edit the item
• false if the item is read-only

This takes into account whether it's in the user's individual vault vs. organization (and if organization, what collection permissions apply).

I'm not familiar with mobile, but it looks like it's available on the SDK model: https://github.com/bitwarden/sdk-internal/blob/main/crates/bitwarden-vault/src/cipher/cipher.rs#L82

[codecov]

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.92%. Comparing base (c4c7af5) to head (23e4a9e).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...warden/ui/vault/feature/item/VaultItemViewModel.kt	37.50%	0 Missing and 5 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4430      +/-   ##
==========================================
- Coverage   88.93%   88.92%   -0.02%     
==========================================
  Files         459      459              
  Lines       39820    39828       +8     
  Branches     5632     5637       +5     
==========================================
+ Hits        35413    35416       +3     
  Misses       2440     2440              
- Partials     1967     1972       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mpbw2]

The server evaluates this business logic for you and sets the result in the cipher.edit property.

Thanks for the heads up on this @eliykat