PM-15356: Resolve biometrics bypass #4448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-livefront
requested review from
brian-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
david-livefront
force-pushed
the
PM-15356-biometrics-bypass
branch
5 times, most recently
from
6dfc5c9 to
3d65749
Compare
MGibson1
reviewed
Dec 11, 2024
| @@ -127,23 +131,23 @@ class SetupUnlockViewModel @Inject constructor( | |||
| } | |||
| } | |||
|
|
|||
| private fun handleUnlockWithBiometricToggle( | |||
| action: SetupUnlockAction.UnlockWithBiometricToggle, | |||
| private fun handleUnlockWithBiometricToggleDisabled() { | |||
dseverns-livefront
previously approved these changes
Dec 12, 2024
david-livefront
force-pushed
the
PM-15356-biometrics-bypass
branch
3 times, most recently
from
cb6b7e5 to
e27dee2
Compare
| // Ignore result so biometrics function on devices that are in a state where key generation | ||
| // is not functioning | ||
| createCipherOrNull(userId) | ||
| private fun destroyBiometrics(userId: String) { |
There was a problem hiding this comment.
👍 like how you condensed this all here!
david-livefront
force-pushed
the
PM-15356-biometrics-bypass
branch
from
e27dee2 to
666d88a
Compare
vvolkgang
force-pushed
the
PM-15356-biometrics-bypass
branch
from
666d88a to
d5d1078
Compare
david-livefront
force-pushed
the
PM-15356-biometrics-bypass
branch
from
d5d1078 to
96d190b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4448 +/- ##
=======================================
Coverage 88.87% 88.87%
=======================================
Files 460 460
Lines 39940 39961 +21
Branches 5691 5694 +3
=======================================
+ Hits 35497 35517 +20
+ Misses 2459 2458 -1
- Partials 1984 1986 +2 ☔ View full report in Codecov by Sentry. |
david-livefront
force-pushed
the
PM-15356-biometrics-bypass
branch
from
96d190b to
b7d256e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-15356
📔 Objective
This PR adds an extra layer of security to the biometrics prompt by signing the user key before storing it, meaning that only a real cipher from the Biometric Prompt can decrypt the data and unlock the vault.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes