Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BWA-10] Sanitize launch intents before processing #128

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

SaintPatrck
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BWA-10

📔 Objective

Validate launch intent data before processing in order to prevent DOS attacks from malicious applications.

📸 Screenshots

Coming soon!

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck requested a review from a team as a code owner June 14, 2024 17:36
Copy link
Contributor

github-actions bot commented Jun 14, 2024

Logo
Checkmarx One – Scan Summary & Detailsde9574ce-7d18-445a-80b1-98d030496c52

No New Or Fixed Issues Found

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.95%. Comparing base (17c9008) to head (76f85a1).

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #128      +/-   ##
========================================
+ Coverage   0.88%   0.95%   +0.06%     
========================================
  Files         84      85       +1     
  Lines       4298    4301       +3     
  Branches     688     691       +3     
========================================
+ Hits          38      41       +3     
  Misses      4255    4255              
  Partials       5       5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SaintPatrck SaintPatrck force-pushed the bwa-10/sanitized-intent branch from 794204b to 76f85a1 Compare June 14, 2024 18:12
@SaintPatrck SaintPatrck merged commit f912e00 into main Jun 14, 2024
11 checks passed
@SaintPatrck SaintPatrck deleted the bwa-10/sanitized-intent branch June 14, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants