Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BWA-33]: Publish release bundles to Play Store when requested #303

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Dec 13, 2024

🎟️ Tracking

BWA-33

📔 Objective

Downloads the authenticator_play_store-creds.json file from Azure blob storage and uses it for publishing to the Google Play Store.

Automatically determine the next version name based on git tags.

If the major and minor versions match the current date, increment the revision. Otherwise, start a new version based on the year and month.

Display version name and code in the workflow summary.

Allow overriding version code and name via workflow inputs.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck requested a review from a team as a code owner December 13, 2024 16:38
Copy link
Contributor

github-actions bot commented Dec 13, 2024

Logo
Checkmarx One – Scan Summary & Detailsc1790896-5b25-49fc-8ac3-730dbdcfb464

No New Or Fixed Issues Found

@SaintPatrck SaintPatrck force-pushed the BWA-33/cannot-upload-to-play-store branch from d232b33 to 8a8695f Compare December 13, 2024 17:22
vvolkgang
vvolkgang previously approved these changes Dec 13, 2024
@SaintPatrck SaintPatrck force-pushed the BWA-33/cannot-upload-to-play-store branch 2 times, most recently from 62b78ce to a92b683 Compare December 13, 2024 18:07
Downloads the `authenticator_play_store-creds.json` file from Azure blob storage and uses it for publishing to the Google Play Store.

Automatically determine the next version name based on git tags.

If the major and minor versions match the current date, increment the revision. Otherwise, start a new version based on the year and month.

Display version name and code in the workflow summary.

Allow overriding version code and name via workflow inputs.
@SaintPatrck SaintPatrck force-pushed the BWA-33/cannot-upload-to-play-store branch from a92b683 to 0c6ead2 Compare December 13, 2024 18:22
@SaintPatrck SaintPatrck changed the title [BWA-33]: Download Play Store credentials from Azure blob storage [BWA-33]: Publish release bundles to Play Store when requested Dec 13, 2024
@SaintPatrck SaintPatrck merged commit 9635bd9 into main Dec 13, 2024
7 of 10 checks passed
@SaintPatrck SaintPatrck deleted the BWA-33/cannot-upload-to-play-store branch December 13, 2024 18:36
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (ad90785) to head (0c6ead2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #303   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants