Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Renovate to monitor Android project dependencies #9

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

SaintPatrck
Copy link
Contributor

🎟️ Tracking

N/A

📔 Objective

Configure Renovate to monitor Android project dependencies.

Kotlin and Compose dependencies will be grouped to to ensure they remain on compatible versions. Compilation will fail when incompatible versions are used. This will result in Kotlin version update PRs to "linger" until the corresponding Compose version is available.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck requested a review from a team as a code owner April 2, 2024 16:57
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Logo
Checkmarx One – Scan Summary & Details8ed25669-9713-4bdf-ad0c-14eb48bbc552

No New Or Fixed Issues Found

Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misnamed file -- should be a replacement.

.github/renovate.json5 Outdated Show resolved Hide resolved
.github/renovate.json5 Outdated Show resolved Hide resolved
.github/renovate.json5 Outdated Show resolved Hide resolved
@SaintPatrck
Copy link
Contributor Author

Misnamed file -- should be a replacement.

I used .json5 so that comments could be added. Renamed back to .json and added a description to the group. Didn't know that description was a property. 🎉

@SaintPatrck SaintPatrck requested a review from withinfocus April 2, 2024 17:33
withinfocus
withinfocus previously approved these changes Apr 2, 2024
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. You'll know quickly once it merges -- just watch #1.

@SaintPatrck SaintPatrck enabled auto-merge (squash) April 2, 2024 17:35
@SaintPatrck SaintPatrck merged commit 580a0ee into main Apr 2, 2024
5 checks passed
@SaintPatrck SaintPatrck deleted the android-renovate-config branch April 2, 2024 21:19
ahaisting-livefront added a commit that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants