Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BWA-76] Updated codeowners #156

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[BWA-76] Updated codeowners #156

wants to merge 2 commits into from

Conversation

vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Sep 24, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BWA-76

📔 Objective

Updates codeowners to the new teams.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested a review from a team as a code owner September 24, 2024 19:29
@vvolkgang vvolkgang changed the title [BWA-77] Updated codeowners [BWA-76] Updated codeowners Sep 24, 2024
Copy link
Contributor

github-actions bot commented Sep 24, 2024

Logo
Checkmarx One – Scan Summary & Details35f03671-27e5-4dba-8aeb-b845170b084e

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 62 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 68

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.43%. Comparing base (dc16a2a) to head (13bb796).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   63.37%   63.43%   +0.05%     
==========================================
  Files         202      202              
  Lines        8685     8685              
==========================================
+ Hits         5504     5509       +5     
+ Misses       3181     3176       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Default file owners
* @bitwarden/dept-development-mobile
# Default file owners.
* @bitwarden/team-ios @matt-livefront @phil-livefront @victor-livefront @brant-livefront
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Do we need to give Matt and Phil permissions of some sort?

@vvolkgang vvolkgang requested a review from a team as a code owner September 24, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants