Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Is-Prerelease header to be integer instead of string #11909

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Nov 7, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13804

📔 Objective

In discussion on the consuming server PR for this change, we determined it would be better to serve this header as an integer (0/1) instead of string (true/false) for a boolean representation.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 changed the title Updated prerelease header to be integer Update Is-Prerelease header to be integer instead of string Nov 7, 2024
@trmartin4 trmartin4 marked this pull request as ready for review November 7, 2024 20:49
@trmartin4 trmartin4 requested a review from withinfocus November 7, 2024 20:50
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.59%. Comparing base (ec92f82) to head (c1df3e3).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
libs/common/src/services/api.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11909      +/-   ##
==========================================
- Coverage   33.59%   33.59%   -0.01%     
==========================================
  Files        2825     2825              
  Lines       88289    88289              
  Branches    16834    16834              
==========================================
- Hits        29665    29658       -7     
- Misses      56301    56308       +7     
  Partials     2323     2323              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Logo
Checkmarx One – Scan Summary & Details9d9640d5-12e5-45b2-8d13-8540ad0c2ea4

No New Or Fixed Issues Found

@trmartin4 trmartin4 merged commit f909855 into main Nov 7, 2024
69 of 71 checks passed
@trmartin4 trmartin4 deleted the auth/pm-13804/adjust-prerelease-header-to-integer branch November 7, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants