[PM-14245] Remove policy definitions feature flag #12172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12172 +/- ##
==========================================
+ Coverage 33.51% 33.53% +0.01%
==========================================
Files 2886 2886
Lines 90183 90152 -31
Branches 17149 17135 -14
==========================================
- Hits 30229 30228 -1
+ Misses 57564 57534 -30
Partials 2390 2390 ☔ View full report in Codecov by Sentry. |
|
Fixed Issues
|
…-13322-add-policy-definitions-from-codebase
BTreston
approved these changes
Dec 3, 2024
…itions-from-codebase
eliykat
deleted the
ac/pm-14245/remove-pm-13322-add-policy-definitions-from-codebase
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14245
📔 Objective
Remove the
Pm13322AddPolicyDefinitionsfeature flag.On the client side, this is permanently removing some client-side validation that was deprecated in favour of server-side validation. This also means that
buildRequestno longer requirespoliciesEnabledMap.Server PR: bitwarden/server#5095
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes