Build desktop-native in alpine container #12499
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,68 +1,82 @@ | ||
| const child_process = require("child_process"); | ||
| const fs = require("fs"); | ||
| const path = require("path"); | ||
| const process = require("process"); | ||
|
|
||
| // contains | ||
| let crossPlatform = "cross-platform" in process.argv; | ||
| let release = "release" in process.argv; | ||
| if (crossPlatform) { | ||
| release = true; | ||
| } | ||
|
|
||
| function buildNapiModule(target, release) { | ||
| const targetArg = target ? `--target ${target}` : ""; | ||
| const releaseArg = release ? "--release" : ""; | ||
| return child_process.execSync(`npm run build -- ${releaseArg} ${targetArg}`, { | ||
| stdio: "inherit", | ||
| cwd: path.join(__dirname, "napi"), | ||
| }); | ||
| } | ||
|
|
||
| function buildProxyBin(target, release) { | ||
| const targetArg = target ? `--target ${target}` : ""; | ||
| const releaseArg = release ? "--release" : ""; | ||
| return child_process.execSync(`cargo build --bin desktop_proxy ${releaseArg} ${targetArg}`, { | ||
| stdio: "inherit", | ||
| cwd: path.join(__dirname, "proxy"), | ||
| }); | ||
| } | ||
|
|
||
| if (!crossPlatform) { | ||
| console.log("Building native modules in debug mode for the native architecture"); | ||
| buildNapiModule(false, release); | ||
| buildProxyBin(false, release); | ||
| return; | ||
| } | ||
|
|
||
| // Note that targets contains pairs of [rust target, node arch] | ||
| // We do this to move the output binaries to a location that can | ||
| // be easily accessed from electron-builder using ${os} and ${arch} | ||
| let targets = []; | ||
| switch (process.platform) { | ||
| case "win32": | ||
| targets = [ | ||
| ["i686-pc-windows-msvc", "ia32"], | ||
| ["x86_64-pc-windows-msvc", "x64"], | ||
| ["aarch64-pc-windows-msvc", "arm64"], | ||
| ]; | ||
| break; | ||
|
|
||
| case "darwin": | ||
| targets = [ | ||
| ["x86_64-apple-darwin", "x64"], | ||
| ["aarch64-apple-darwin", "arm64"], | ||
| ]; | ||
| break; | ||
|
|
||
| default: | ||
| targets = [["x86_64-unknown-linux-musl", "x64"]]; | ||
|
|
||
| process.env["PKG_CONFIG_ALLOW_CROSS"] = "1"; | ||
| process.env["PKG_CONFIG_ALL_STATIC"] = "1"; | ||
| break; | ||
| } | ||
|
|
||
| console.log( | ||
| "Cross building native modules for the targets: ", | ||
| targets.map(([target, _]) => target).join(", "), | ||
| ); | ||
|
|
||
| fs.mkdirSync(path.join(__dirname, "dist"), { recursive: true }); | ||
|
|
||
| targets.forEach(([target, nodeArch]) => { | ||
| buildNapiModule(target, release); | ||
| buildProxyBin(target, release); | ||
|
|
||
| const ext = process.platform === "win32" ? ".exe" : ""; | ||
| fs.copyFileSync( | ||
| path.join(__dirname, "target", target, "release", `desktop_proxy${ext}`), | ||
| path.join(__dirname, "dist", `desktop_proxy.${process.platform}-${nodeArch}${ext}`), | ||
| ); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed this new job doesn't have a cache step, do we know how long it takes to build? Not sure if it was needed before, but I'd rather not accidentally make the builds any slower hah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~4 minutes https://github.com/quexten/clients/actions/runs/12430521534/job/34706128211
So adding cache is worth it.