Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16265] Add missing credit card number pipe #12508

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

djsmith85
Copy link
Contributor

@djsmith85 djsmith85 commented Dec 20, 2024

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-16265

๐Ÿ“” Objective

Fixes #12505

While migrating the credit card view, the formatting for credit card numbers was missed. This pipe takes care of different credit card spacing patterns based on the brand

๐Ÿ“ธ Screenshots

Before

image

After

image

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested a review from a team as a code owner December 20, 2024 16:29
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ f94806a7-c4cc-4f75-a2a1-71e6b82dd2fe

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 33.60%. Comparing base (b27a1a5) to head (be4d279).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12508      +/-   ##
==========================================
- Coverage   33.61%   33.60%   -0.02%     
==========================================
  Files        2925     2925              
  Lines       91433    91455      +22     
  Branches    17376    17384       +8     
==========================================
- Hits        30734    30730       -4     
- Misses      58283    58308      +25     
- Partials     2416     2417       +1     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Card numbers are not formatted
1 participant