-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-15591 UI is showing when mp reprompt is on #12515
PM-15591 UI is showing when mp reprompt is on #12515
Conversation
…logins' into PM-15591-ui-is-showing-when-mp-reprompt-is-on
New Issues
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12515 +/- ##
==========================================
- Coverage 33.78% 33.78% -0.01%
==========================================
Files 2912 2912
Lines 90693 90694 +1
Branches 17151 17152 +1
==========================================
Hits 30641 30641
Misses 57666 57666
- Partials 2386 2387 +1 ☔ View full report in Codecov by Sentry. |
totpCodeSpan.textContent = formattedTotpCode; | ||
totpCodeSpan.classList.toggle("cipher-subtitle"); | ||
totpCodeSpan.classList.toggle("masked-totp", !!reprompt); | ||
totpCodeSpan.textContent = reprompt ? "●●●●●●" : formattedTotpCode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simple and neat! ✨
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15591
📔 Objective
When reprompt is enabled, mask the totp number shown in the inline menu
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes