Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7105][PM-7242][PM-16256] Remove v1 code for Tab/Vault Part 2 #12516

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

djsmith85
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16256

📔 Objective

With #12485 I already removed the conditional routing to the new Vault UI based on the ExtensionRefresh-feature flag. This PR aims to continue the removal of all conditional routings for vault-owned components, but also goes ahead and deletes all the now unused v1 Vault code.

Removing the conditional routing is needed, as the new Vault UI would show, but once a user clicks on edit or creates a new item, they would be presented with the old Add/Edit UI.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested a review from a team as a code owner December 20, 2024 20:17
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details017288ab-7e42-4bfe-a6b7-52a631824f3c

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 276 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/attachments.component.html: 25
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/attachments.component.html: 25
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/cipher-row.component.ts: 11
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/cipher-row.component.ts: 11
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/password-history.component.html: 18
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/password-history.component.html: 18
LOW Client_DOM_Open_Redirect /apps/browser/src/vault/popup/components/vault/attachments.component.ts: 37
LOW Client_DOM_Open_Redirect /apps/browser/src/vault/popup/components/vault/password-history.component.ts: 23

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.30%. Comparing base (0619ef5) to head (862d420).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...lt/popup/components/vault-v2/vault-v2.component.ts 0.00% 2 Missing ⚠️
apps/browser/src/popup/app-routing.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12516      +/-   ##
==========================================
+ Coverage   33.78%   34.30%   +0.52%     
==========================================
  Files        2912     2893      -19     
  Lines       90693    89317    -1376     
  Branches    17151    16782     -369     
==========================================
  Hits        30641    30641              
+ Misses      57666    56290    -1376     
  Partials     2386     2386              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djsmith85 djsmith85 changed the title [PM-16256] Remove v1 code for Tab/Vault Part 2 [PM-7242][PM-16256] Remove v1 code for Tab/Vault Part 2 Dec 20, 2024
@djsmith85 djsmith85 changed the title [PM-7242][PM-16256] Remove v1 code for Tab/Vault Part 2 [PM-7105][PM-7242][PM-16256] Remove v1 code for Tab/Vault Part 2 Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant