Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12606] Move Vault Timeout and Vault Timeout Settings to Key Management #12517

Open
wants to merge 8 commits into
base: km/pm-11528/move-lock-to-km
Choose a base branch
from
+333 −242

fix tests

19d7d4d
Select commit
Loading
Failed to load commit list.
Open

[PM-12606] Move Vault Timeout and Vault Timeout Settings to Key Management #12517

fix tests
19d7d4d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 23, 2024 in 0s

33.60% (+0.03%) compared to 8cad5e6

View this Pull Request on Codecov

33.60% (+0.03%) compared to 8cad5e6

Details

Codecov Report

Attention: Patch coverage is 57.69231% with 22 lines in your changes missing coverage. Please review.

Project coverage is 33.60%. Comparing base (8cad5e6) to head (19d7d4d).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../auth/popup/settings/account-security.component.ts 0.00% 3 Missing ⚠️
apps/browser/src/background/main.background.ts 0.00% 2 Missing ⚠️
...rc/services/vault-timeout/vault-timeout.service.ts 0.00% 2 Missing ⚠️
apps/desktop/src/app/services/init.service.ts 0.00% 2 Missing ⚠️
...up/account-switching/account-switcher.component.ts 0.00% 1 Missing ⚠️
...th/popup/settings/account-security-v1.component.ts 0.00% 1 Missing ⚠️
...th/popup/settings/vault-timeout-input.component.ts 0.00% 1 Missing ⚠️
apps/browser/src/background/idle.background.ts 0.00% 1 Missing ⚠️
.../vault-timeout/foreground-vault-timeout.service.ts 0.00% 1 Missing ⚠️
...pps/desktop/src/app/accounts/settings.component.ts 0.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files 
@@                       Coverage Diff                       @@
##           km/pm-11528/move-lock-to-km   #12517      +/-   ##
===============================================================
+ Coverage                        33.57%   33.60%   +0.03%     
===============================================================
  Files                             2927     2927              
  Lines                            91536    91498      -38     
  Branches                         17395    17395              
===============================================================
+ Hits                             30729    30752      +23     
+ Misses                           58393    58332      -61     
  Partials                          2414     2414

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov