Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16259] Remove v1 popout component #12518

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

djsmith85
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-16259

๐Ÿ“” Objective

Removing the conditional rendering of the popout component based on the ExtensionRefresh feature flag

๐Ÿ“ธ Screenshots

Before After
image image

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested a review from a team as a code owner December 20, 2024 20:50
@djsmith85 djsmith85 requested a review from coroiu December 20, 2024 20:50
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 486c16e0-9725-4aa5-981d-2d2c78979681

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.78%. Comparing base (0619ef5) to head (37bc392).

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...src/platform/popup/components/pop-out.component.ts 0.00% 0 Missing and 1 partial โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12518      +/-   ##
==========================================
- Coverage   33.78%   33.78%   -0.01%     
==========================================
  Files        2912     2912              
  Lines       90693    90688       -5     
  Branches    17151    17150       -1     
==========================================
- Hits        30641    30636       -5     
  Misses      57666    57666              
  Partials     2386     2386              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant