-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-16428] Option for primary click action to autofill on Vault view #12557
base: main
Are you sure you want to change the base?
Conversation
...popup/components/vault-v2/autofill-vault-list-items/autofill-vault-list-items.component.html
Outdated
Show resolved
Hide resolved
New Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12557 +/- ##
==========================================
- Coverage 33.78% 33.77% -0.01%
==========================================
Files 2912 2912
Lines 90693 90710 +17
Branches 17151 17153 +2
==========================================
Hits 30641 30641
- Misses 57666 57683 +17
Partials 2386 2386 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(smoke-tested as well; everything behaves as expected)
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16428
📔 Objective
📸 Screenshots
New autofill setting
Vault view
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes