Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16428] Option for primary click action to autofill on Vault view #12557

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kspearrin
Copy link
Member

@kspearrin kspearrin commented Dec 23, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16428

📔 Objective

  • Add an option/setting for the primary action of autofill suggestions on the Vault view to perform an "Autofill" operation instead of the default "View" action.
  • "View" becomes an option under the 3 dot "more options" menu.
  • "Fill" button goes away.

📸 Screenshots

New autofill setting

image

Vault view

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 23, 2024

Logo
Checkmarx One – Scan Summary & Detailsc40870bb-f385-453c-acdd-8e0f244ae1ad

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH CVE-2024-11395 Npm-electron-33.2.1 Vulnerable Package
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/settings/autofill.component.html: 40 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/settings/autofill.component.html: 107 Attack Vector

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 33.77%. Comparing base (0619ef5) to head (05fd131).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...-list-items/autofill-vault-list-items.component.ts 0.00% 7 Missing ⚠️
...2/item-more-options/item-more-options.component.ts 0.00% 4 Missing ⚠️
.../services/vault-settings/vault-settings.service.ts 0.00% 4 Missing ⚠️
.../src/autofill/popup/settings/autofill.component.ts 0.00% 3 Missing ⚠️
...c/vault/services/key-state/vault-settings.state.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12557      +/-   ##
==========================================
- Coverage   33.78%   33.77%   -0.01%     
==========================================
  Files        2912     2912              
  Lines       90693    90710      +17     
  Branches    17151    17153       +2     
==========================================
  Hits        30641    30641              
- Misses      57666    57683      +17     
  Partials     2386     2386              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kspearrin kspearrin changed the title Option for primary click action to autofill Option for primary click action to autofill on Vault view Dec 23, 2024
@kspearrin kspearrin changed the title Option for primary click action to autofill on Vault view [PM-16428] Option for primary click action to autofill on Vault view Dec 23, 2024
@kspearrin kspearrin marked this pull request as ready for review December 23, 2024 14:03
@kspearrin kspearrin requested review from a team as code owners December 23, 2024 14:03
@merissaacosta merissaacosta requested review from shane-melton and vleague2 and removed request for cd-bitwarden December 23, 2024 14:33
@jprusik jprusik self-requested a review December 23, 2024 15:32
Copy link
Contributor

@jprusik jprusik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(smoke-tested as well; everything behaves as expected)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants